This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Total in the payment and preferred accounts in the homeview

Tags: None
(comma "," separated)
goedel
Registered Member
Posts
10
Karma
0
Hi,
I made a little patch to add the total for the payment and preferred accounts list in the homeview, do you think it can be integrated in the main src?
User avatar
Hei Ku
Registered Member
Posts
784
Karma
3
OS
What is the patch about?


Hei Ku, proud to be a member of the KMyMoney Development Team since January-2008
goedel
Registered Member
Posts
10
Karma
0
It simply add a row "Total" in the payment accounts list and in the preferred accounts list in the home view.
User avatar
Hei Ku
Registered Member
Posts
784
Karma
3
OS
Great.

You can send the patch file to our mailing list. kmymoney-devel at kde.org


Hei Ku, proud to be a member of the KMyMoney Development Team since January-2008
User avatar
ipwizard
KDE Developer
Posts
1359
Karma
6
OS
Can you drop it in KDE's reviewboard at https://git.reviewboard.kde.org/ so that we can take a look and integrate it? Please provide a patch against git master and use kmymoney as the repository.

OK: Hei Ku beats me here. Sending it to the developer list so that we can add it to reviewboard ;) is equally good.


ipwizard, proud to be a member of the KMyMoney forum since its beginning. :-D
openSuSE Leap 15.4 64bit, KF5
User avatar
Hei Ku
Registered Member
Posts
784
Karma
3
OS
I went for the easy way, as you are likely not familiarized with reviewboard, and the patch must be simple enough to handle it manually. :)


Hei Ku, proud to be a member of the KMyMoney Development Team since January-2008
goedel
Registered Member
Posts
10
Karma
0
Hum.. I created a review request, I don't know if it's ok as this is the first time that I use the reviewboard.

https://git.reviewboard.kde.org/r/106434/
User avatar
Hei Ku
Registered Member
Posts
784
Karma
3
OS
You posted it correctly. I'll review it and comment on it.


Hei Ku, proud to be a member of the KMyMoney Development Team since January-2008
goedel
Registered Member
Posts
10
Karma
0
I fixed it by your suggestions and uploaded another diff, now what?
User avatar
Hei Ku
Registered Member
Posts
784
Karma
3
OS
We review it again, test it again, and then push it to master if it's ok


Hei Ku, proud to be a member of the KMyMoney Development Team since January-2008


Bookmarks



Who is online

Registered users: Bing [Bot], Evergrowing, Google [Bot]