This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Migration to AlkValue

Tags: None
(comma "," separated)
kaduardo
Registered Member
Posts
15
Karma
0
OS

Migration to AlkValue

Sun Aug 22, 2010 8:59 am
Hi guys,

I have finished the changes in the MyMoneyMoney class for using AlkValue.

The code is passing all unit tests, but I had to change some code in the mymoneymoneytest due to the removal of the m_num and m_denom variables, and for using normalized values when comparing against expected values (e.g., testMultiplication).

I tried running the software, but it crashes with segmentation fault.

Since I am not that proficient with C++ (last time I used it was in 2001), I think I may have committed some mistakes in the MyMoneyMoney class that somehow passed the unit tests.

Can someone take a look in this code?
I am using Kdevelop, and have created a .patch file that I can send by e-mail.

Cheers,
Carlos
User avatar
ipwizard
KDE Developer
Posts
1359
Karma
6
OS

Re: Migration to AlkValue

Sun Aug 22, 2010 3:14 pm
Let's work on this together. I'll send you my e-mail address separately.


ipwizard, proud to be a member of the KMyMoney forum since its beginning. :-D
openSuSE Leap 15.4 64bit, KF5
User avatar
Hei Ku
Registered Member
Posts
784
Karma
3
OS

Re: Migration to AlkValue

Mon Aug 23, 2010 12:33 am
When you are done, this should go through ReviewBoard.


Hei Ku, proud to be a member of the KMyMoney Development Team since January-2008
kaduardo
Registered Member
Posts
15
Karma
0
OS

Re: Migration to AlkValue

Thu Sep 09, 2010 8:20 am
Just one more question before I submit the patch to Reviewboard.

I had to checkout the libalkimia library and save it in the root directory of the kmymoney project (together with libkdchart, and libkgpgfile), and to alter several of the CMakeLists.txt files for including the libalkimia and the GMP libraries.

Do I include the libalkimia directory in the patch (removing the reference to its original repository)?
kaduardo
Registered Member
Posts
15
Karma
0
OS

Re: Migration to AlkValue

Thu Oct 14, 2010 9:06 pm
I have submitted the code to review board.

I have been using it for almost a month without any problems.

Can someone take a look at the code on ReviewBoard to see if I missed something?


Bookmarks



Who is online

Registered users: abc72656, Bing [Bot], daret, Google [Bot], lockheed, Sogou [Bot], Yahoo [Bot]