Administrator
|
Here you can discuss Kourse 1 apart from the main action.
|
Alumni
|
I think bugfixing ksnapshot was a good choice for kourse 1. It is a relatively simple and small program to understand, so people new to KDE development can follow the logic of the codes quite ok.
Thanks to msoeken, the mentor for kourse 1, for your sugggestions and tips. Kudos also to the other mentors/coordinators for organizing this kourses/klassrooms. Ironically though, too bad ksnapshot does not have too many bugs. I think we were literally short of bugs!
Last edited by Linex on Thu Jan 01, 2009 1:25 pm, edited 1 time in total.
Alsagoff, proud to be a member of KDE forums since 2008-Dec.
|
Mentor
|
Sadly I did not have the time that I could spent that I wanted to because of some circumstances. But nevertheless, I think we managed it very well. Thanks to the students and to the moderators. In a summary we have two patches from (one of them needs just small changes) and a patch to a wish, which is also on a good way as far as I can see. One student is working on detecting some problems with KHotKeys which causes problems in ksnapshot (too many instances) and which also could cause problems in other applications.
But what did we learn from the first kourse? Here are some points which could be improved the next time
[size=x-small]code | [url=cia.vc/stats/author/msoeken]cia.vc[/url] | [url=kde.org/support]donating KDE[/url] | [url=tinyurl.com/cto4ns]wishlist[/url][/size] |
KDE Developer
|
Yes thank you for your work msoeken. And I can't wait for another one from you in due time. Yeah I think it would really be good for klasses to have the maintainer to help with the mentor and the students. Sorry about my patch >.< My first time hehe, but wish I did a little more digging. But I hope it does well.
Last edited by ComaWhite on Sat Jan 03, 2009 6:27 am, edited 1 time in total.
|
Alumni
|
Unfortunately I hadn't enough time back then when this Kourse was fresh and I wasn't even a student... But nevertheless this whole thing gave me a brilliant insight into KDE development and finally I would like to show you my first patch at this point.
I have played about ComaWhite's solution for the "close KSnapShot when screenshot is opened with another application" (Wish #165482)
There now is a Checkbox right under the "Open with" Button - I think it's the appropriate place for it as long as there are not enought options for a real "options area"...
Last edited by msoeken on Sun Jan 04, 2009 8:44 pm, edited 1 time in total.
michael4910, proud to be a member of KDE forums since 2008-Oct.
|
Mentor
|
The patch looks good. But the state of the checkbox should be saved after quitting the program and restored when starting it. [size=x-small]code | [url=cia.vc/stats/author/msoeken]cia.vc[/url] | [url=kde.org/support]donating KDE[/url] | [url=tinyurl.com/cto4ns]wishlist[/url][/size] |
Alumni
|
That sounds plausible...
After a while on the KDE API pages, in Qt Assistant and on last.fm I'm somehow satisfied in having gone the next step on my way onto the KDE programming olymp! yeah! Here it comes: Kconfig stores the state of the checkbox...
Last edited by msoeken on Tue Jan 06, 2009 7:05 am, edited 1 time in total.
michael4910, proud to be a member of KDE forums since 2008-Oct.
|
Mentor
|
Great that you enjoy KDE programming. Loading the option looks ok, but there is some problems with writing.
[size=x-small]code | [url=cia.vc/stats/author/msoeken]cia.vc[/url] | [url=kde.org/support]donating KDE[/url] | [url=tinyurl.com/cto4ns]wishlist[/url][/size] |
Alumni
|
ahrgh - you're right. Using the toggled-signal is really much better...
Do you still see some space for improvements?
Last edited by michael4910 on Fri Jan 09, 2009 7:07 pm, edited 1 time in total.
michael4910, proud to be a member of KDE forums since 2008-Oct.
|
Mentor
|
Looks very good. If you want to, you can send the patch to the kdegraphics mailing list or send it to the maintainer Richard (you will find his email in the about dialog). Feature freeze is over and so it could go directly into trunk. If you have further questions, feel free to ask. Cheers, m [size=x-small]code | [url=cia.vc/stats/author/msoeken]cia.vc[/url] | [url=kde.org/support]donating KDE[/url] | [url=tinyurl.com/cto4ns]wishlist[/url][/size] |
Alumni
|
thanks for helping me with my first patch... ,-)
I just see that bugs.kde.org also has the possibility to add it as attachment... Is there a prefered way to continue with a patch?
michael4910, proud to be a member of KDE forums since 2008-Oct.
|
Administrator
|
Patches for things like this ( feature additions ) are usually sent to the mailing list and suggestions can then be made by other developers.
For things like bugs, they can be added to the affected bug, or sent to the mailing list. The best way to get commentary on a patch is usually the mailing lists.
KDE Sysadmin
[img]content/bcooksley_sig.png[/img] |
Registered Member
|
this is the best palce to learn the KDE programming, i'm an amateur...
where can i find it exactly: QAbstractButton::toggled ? |
Registered users: Bing [Bot], claydoh, Google [Bot], paulgureghian, Yahoo [Bot]