This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Unneeded assert in blueNorm()

Tags: None
(comma "," separated)
twood
Registered Member
Posts
17
Karma
0

Unneeded assert in blueNorm()

Wed Sep 05, 2012 10:51 am
Hello,
I've just had a program hit the following assert on line 134 of StableNorm.h:
Code: Select all
eigen_assert(false && "overflow");

Is this supposed to be there? Line 135 is:
Code: Select all
return rbig;

Which suggests to me the algorithm is supposed to return a value even in the case of overflow, and the assert is stopping this from happening. I had never heard of Blue's algorithm before today, so don't know what the correct behaviour is. For reference, blueNorm() was called from line 221 of LevenbergMarquardt.h (in the Non-linear optimisers unsupported module).

For the time being I have commented out the assert with apparently no ill effect (famous last words).
User avatar
ggael
Moderator
Posts
3447
Karma
19
OS

Re: Unneeded assert in blueNorm()

Fri Sep 07, 2012 9:23 pm
You're right, fixed:

https://bitbucket.org/eigen/eigen/chang ... 45a2f4b76/
changeset: 17345a2f4b76
user: ggael
date: 2012-09-07 23:19:24
summary: remove stupid assert in blue norm.


Bookmarks



Who is online

Registered users: Baidu [Spider], Bing [Bot], Google [Bot], Yahoo [Bot]