Compiling my project with Eigen and using the -Weffc++ warnings I get many warnings coming from inside of Eigen.

I get hundreds of wanting like these:

Code: Select all

/usr/local/include/eigen3/Eigen/src/Core/NumTraits.h:91:19: warning: base class 'struct Eigen::GenericNumTraits<float>' has a non-virtual destructor [-Weffc++]

Is Eigen planning on supporting these warnings?

For now, is there an easy way to ignore only these coming from Eigen?

hm, this warning is silly since GenericNumTraits has only static members. I guess that doing :

Code: Select all

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored
#include <Eigen/Eigen>
#pragma GCC diagnostic pop


should do the job. If that work, we can do this inside Eigen with the appropriate compiler checks.