This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Submitting dummy pull request

Tags: None
(comma "," separated)
rafaelguglielmetti
Registered Member
Posts
15
Karma
0
OS

Submitting dummy pull request

Fri Dec 16, 2016 9:12 am
Dear Eigen devs,
Suppose I have a small modification for the documentation.

As I understood, I have two possibilities:
1. Do it locally, and create a patch file.
2. Fork the code and do the modification on bitbucket, then create a pull request.

I tried 1. but I don't know what to do with the file
I then tried 2. (https://bitbucket.org/rgugliel/eigen/pull-requests/) but then I don't know what to do with that

What is the best way to do?

Thanks a lot.

Best.

Raf
User avatar
ggael
Moderator
Posts
3447
Karma
19
OS

Re: Submitting dummy pull request

Fri Dec 16, 2016 9:28 am
You need to do the pull-request to the original eigen/eigen repository, not from your local branch towards your default branch. BTW, please avoid named-branches with mercurial! Mercurial branches and git branches have nothing in common! In mercurial, names branches should be reserved for long term branches, like 3.x series.
User avatar
ggael
Moderator
Posts
3447
Karma
19
OS
I did the merge manually to bypass your named branch.
rafaelguglielmetti
Registered Member
Posts
15
Karma
0
OS

Re: Submitting dummy pull request

Fri Dec 16, 2016 9:31 am
Ooops. I created the pr just before your second message. Sorry.


Bookmarks



Who is online

Registered users: Bing [Bot], Google [Bot], Sogou [Bot]