I'm currently using svn to keep track of the changes in our projects, including which version of eigen3 is used.

We had to modify 2 cmake files to make it work.
Eigen\CMakeList.txt and Eigen\src\CMakeList.txt

The change goes like this for Eigen\CMakeList.txt
foreach(f ${Eigen_directory_files})
if(NOT f MATCHES ".txt" AND NOT f MATCHES ".svn" AND NOT f MATCHES "${CMAKE_CURRENT_SOURCE_DIR}/src")
list(APPEND Eigen_directory_files_to_install ${f})
endif()
endforeach(f ${Eigen_directory_files})

Eigen\src\CMakeList.txt is the same change.

Basically, it works by excluding the .svn directory of the cmake generation process.

I'd like to know how I can submit this improvement.

Thank you,

We need a more general solution here so we don't have to special-case every VCS.

How about excluding all files/directories starting with '.' ? (i.e. unix hidden files) If you make a patch doing that I think we can accept it.

I personnally don't see a problem on my side. I'll test it to make sure with.

There is already a ".txt" being filtered.

MATCHES means contains, not starts-with.

The .txt here is meant to match CMakeLists.txt

You need to find a way in CMake to test if a string starts with '.' . This should be explained in the cmake manual page, at the 'string' command.

The regex string to use is "[.].+".

It remove anything that start with "." with any character following.

So, how do I submit the new code?

Thank you,

Preferably by generating a patch as described on http://eigen.tuxfamily.org/index.php?title=Mercurial and then submitting it to our Bugzilla issue tracker: http://eigen.tuxfamily.org/bz .

Patch is submitted in the bug 90 in bugzilla.

Can someone confirm that all is in order procedure wise?
It is my first try.

Thank you.

(Discussing continued over at the bug)