frederik wrote:For Step, I think that upload should be implemented - anyone up for grabbing this one?

I'll take a go at it.

EDIT

frederik wrote:Hans will work on this.

Oh, do you mean @Hans will work on the upload feature?

deltaecho wrote:

frederik wrote:Hans will work on this.

Oh, do you mean @Hans will work on the upload feature?

I think frederik wrote that reply before seeing my post, and after reading that I would work on uploading in Step he edited his post.

Anyway, here's the patch :

• Step uploading - http://pastebin.com/3DRWPw4f

The upload button in the dialog is always grayed out - I guess it's because Step doesn't have a category yet? - so I can't try it out.

Hi everyone!
It's been a while, I underestimated how little time I'd manage to spend on this course during tokamak. Sorry for that. I'll get the patches that have been posted in now and go through the list to see how we managed.

Hans wrote:2. Kopete
a) Kopete doesn't appear to have a .knsrc file (or I've somehow failed to find it) - should I create one instead of using KConfigGroup?

Basically this creates the .knsrc file by hand and overwrites it each time the dialog is shown. I think it would be nice to create a .knsrc file instead. Also you could simply use DownloadDialog::installedEntries() instead of DownloadDialog::changedEntries() to save one or two lines of code.

Hans wrote:b) I couldn't get

Code: Select all

ProvidersUrl=http://download.kde.org/ocs/providers.xml

to work. What's the category for Kopete Styles 0.12+? I tried to use

Code: Select all

Categories=Window Decoration native KDE 4

but that didn't work either.

The category should be the same as on the website. If it doesn't appear in the contents listing (see somewhere above) it needs to be added. Please let me know in this case.

Hans wrote:I think frederik wrote that reply before seeing my post, and after reading that I would work on uploading in Step he edited his post.

Anyway, here's the patch :

• Step uploading - http://pastebin.com/3DRWPw4f

The upload button in the dialog is always grayed out - I guess it's because Step doesn't have a category yet? - so I can't try it out.

Sorry for the confusion, I didn't see that Hans wrote that he'd go for the step additions at first.

About the upload dialog: to let apps have more fine grained control over uploading, it needs a "UploadCategories=Step" in the knsrc file.
In addition, uploading only works with the openDesktop/kde-files etc sites so far. Step currently only uses edu.kde.org as provider. I sent Vladimir and Frank a mail if they want to add Step to kde-files.org.

frederik wrote:I sent Vladimir and Frank a mail if they want to add Step to kde-files.org.

Awesome, thanks! Also, thank you for your comments - I'll try to work on them tomorrow (well, today in my time zone ;).

Ok, finally the KCMs - did I miss any question or patch? I'll read through the thread after writing this, but better point out to me if I overlooked something!

Dynamite wrote:I have changed KDM to KNewStuff3 in both dialogs (Wallpaper and Theme).
Diff: http://www.pastebin.org/94085

In order to use the newer server api, don't use the specific xml feeds here:

Code: Select all

ProvidersUrl=http://download.kde.org/khotnewstuff/kdmthemes4-providers.xml

but rather the general one:

Code: Select all

ProvidersUrl=http://download.kde.org/ocs/providers.xml

Maybe it would be good to clean up with some of the comments in the file too, but that is probably not easy without getting in touch with the author or someone else working on the KCM.

Dynamite wrote:Updated KCM Style.
Diff: http://www.pastebin.org/94107

Same for the ProvidersUrl as above and then the category is missing.

Thanks!

I think Wednesday is a good time to let the course end, then it's been two weeks. As far as I can see, there are still some of the KCMs left to be ported, does anyone care for them? Ok, here is the state as far as I can see:

finished (in svn):
Kalzium
KWordQuiz, KAnagram
Ksirk, Kigo

in progress:
Step and Kopete
Marble (twice even, _eti_/ruediger, needs to be committed still)
Emoticons-KCM
KDM and Style

not done:
Granatier
Plasma Weather
KCMs (color, splash),
KStars

New patch:

• Step uploading - http://pastebin.com/SYcfWwTQ
  Won't work until there's a "Step" category on kde-files (the knsrc file has to be changed if the category is named something else)

frederik wrote:The category should be the same as on the website. If it doesn't appear in the contents listing (see somewhere above) it needs to be added. Please let me know in this case.

Kopete styles aren't listed on http://api.opendesktop.org/v1/content/categories. Is this also why it doesn't show any items with the new ProvidersUrl?

frederik wrote:Also you could simply use DownloadDialog::installedEntries() instead of DownloadDialog::changedEntries() to save one or two lines of code.

I don't quite see how to do this. I still have to check if the styles are installed correctly and increment correctlyInstalled, right? In that case, the only line I see that might be omitted is

Code: Select all

if ( entry.status() == KNS3::Entry::Installed && entry.installedFiles().size() > 0 )

Correct?

Work in process:

• Kopete - http://pastebin.com/dg0kRxNm

Here is my patch for KStars:
http://codepad.org/fMzVh0Sn

New patch for Style: http://www.pastebin.org/99997
for KDM: http://www.pastebin.org/99998

KAnagram isn't finished (At least not from me). I still have some issues and didn't try to solve them yet.

I just posted the Marble patch to the reviewboard:
http://reviewboard.kde.org/r/3085/

Here's a patch for colors kcm, the upload part:
http://www.kolumbus.fi/lliehu/patches/c ... load.patch
I tested it quite a bit, but didn't try to actually upload anything (click Upload... in the UploadDialog etc.)
The download part has been done and committed already.

Concerning splash kcm: I've basically done it, but it seems a category for splash screens is missing from the OpenDesktop API. I've mailed frank, but there hasn't been an answer yet.

Also who should I contact when I'd like to make some non-ghns patches for colors kcm, basically a few things that are marked as TODOs in code?

You should contact the maintainer of the colours KCM for information regarding those TODO items.

You should be able to ask on kde-devel or kde-core-devel for pointers to the right person. Patches fixing those TODO's are in most cases appreciated.

Oh great, I just thought that I was unable to use patch - usually it's just

Code: Select all

patch -p0 < patchfile.diff

to apply svn diff patches. But pastebin.org manages to eat @@ in the diff file. That leads to patch not liking the file any more. I'll fix it by hand now... but I suggest using a different pastebin the next time.

Hi all, I've wanted to write an official "now it's over" for a week now. Finally it's time.
I'd be happy if forum people (we have enough in here, right?) could create a feedback thread and do the necessary moving around of stuff since I'd most likely mess it up

I hope you enjoyed this little course. I think it was quite productive and fun!
I'm curious what your feedback to this Klassroom is, and if you think tasks like the one we tackled are a good topic.

Thanks for participating!