This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Krazy fixes 2

Tags: None
(comma "," separated)
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 8:25 am
kdesupport/cpptoxml
Check for strings used improperly or should be i18n.
http://pastebin.com/DVYSSDfw
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 8:36 am
kdesupport/cpptoxml
Check for C++ operators that should be 'const'
http://pastebin.com/QD6UKnwf
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 8:40 am
kdesupport/cpptoxml
Check for compares to QString::null or QString()
http://pastebin.com/Jqcd8T0D
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 8:46 am
kdesupport/cpptoxml
Check for assignments to QString::null
http://pastebin.com/Qber2VPV
User avatar
bcooksley
Administrator
Posts
19765
Karma
87
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 9:52 am
Both patches look really good Glen. Both can be submitted to the kdelibs review group so they can be reviewed by kde-core-devel.


KDE Sysadmin
[img]content/bcooksley_sig.png[/img]
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 7:56 pm
Both? I take it you're talking attica and automoc?
User avatar
bcooksley
Administrator
Posts
19765
Karma
87
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 8:15 pm
Correct, the attica and automoc4 patches are the patches I was referring to.


KDE Sysadmin
[img]content/bcooksley_sig.png[/img]
lliehu
Alumni
Posts
9
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 8:39 pm
kdepim/kjots fixes for categories crashy, explicit and spelling: http://pastebin.com/uE90y48v

With this I think kjots is quite finished (some i18n issues still exist, but I'm not sure if I can fix those). Is there any program or module or anything that'd need fixing? Otherwise I'll just take something more to do randomly I guess.
User avatar
bcooksley
Administrator
Posts
19765
Karma
87
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 9:04 pm
Patch for kjots looks good, can you submit it to reviewboard so the PIM developers can review it?

You are welcome to choose any module or application that you would like to work on. Those with higher krazy issue counts will likely have a wider variety of issues to fix however.


KDE Sysadmin
[img]content/bcooksley_sig.png[/img]
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 10:23 pm
kdesupport/cpptoxml
Check for proper include directives
http://pastebin.com/XA539xh3
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 10:36 pm
kdesupport/cpptoxml
Check for foreach loop issues
http://pastebin.com/rC0cm9BE
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 10:39 pm
kdesupport/cpptoxml
Check for C++ ctors that should be declared 'explicit'
http://pastebin.com/FcPtgvgm
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 10:45 pm
kdesupport/cpptoxml
Check single-char QString operations for efficiency
http://pastebin.com/AsNTdzTQ
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 10:47 pm
So can I ignore stuff like the following?

#if defined(__GNUC__)
#warning "ptr to mem -- not implemented"
#endif
Glen Kaukola
Alumni
Posts
39
Karma
0
OS

Re: Krazy fixes 2

Fri Mar 26, 2010 10:48 pm
And this one as well?

#if defined(_WIN64) || defined(WIN64) || defined(__WIN64__) \
|| defined(_WIN32) || defined(WIN32) || defined(__WIN32__)
# define PP_OS_WIN
#endif


Bookmarks



Who is online

Registered users: Bing [Bot], Google [Bot], kesang, Sogou [Bot], Yahoo [Bot]