And question: Is there anything else I should be doing besides simply posting to the review board to alert people that something's there?

Nevermind. I just noticed it fires something off to a mailing list when I publish.

Glen Kaukola wrote:So can I ignore stuff like the following?

#if defined(__GNUC__)
#warning "ptr to mem -- not implemented"
#endif

Glen Kaukola wrote:#if defined(_WIN64) || defined(WIN64) || defined(__WIN64__) \
|| defined(_WIN32) || defined(WIN32) || defined(__WIN32__)
# define PP_OS_WIN
#endif

Yes, these can be ignored, as they are messages from the developers to remind themselves / warn themselves of unfinished areas to work on later.

The includes, foreach, explicit ctors and single char QString patches are all good and can be submitted to reviewboard also.

bcooksley wrote:The includes, foreach, explicit ctors and single char QString patches are all good and can be submitted to reviewboard also.

Would I put cpptoxml under the kdelibs group as well?

Yes, as that component is probably maintained by someone on kde-core-devel ( or someone on that list will know who to get to review it )

Reviewboard is saying that switching to d pointers isn't binary compatible, so any changes like that to kdesupport/attica can't be done.
http://reviewboard.kde.org/r/3401/

The guy doing the reviewing seems unsure as to whether or not changing:
Private* d;
to:
Private * const d;
breaks binary compatibility. Does it?

Judging by Techbase I would say it breaks Binary Compatibility.

Glen Kaukola wrote:kdesupport/cpptoxml
Check for C++ operators that should be 'const'
http://pastebin.com/QD6UKnwf

http://reviewboard.kde.org/r/3423/
The review board is saying changes should probably be like so:

Code: Select all

bool const operator==(const TypeInfo &other);

as opposed to:

Code: Select all

const bool operator==(const TypeInfo &other);

Sound about right?

Yes it does, since it isn't the bool which is const, but the compare operation itself...

kdegraphics/okular
Check for Qt classes that should not be used.
http://pastebin.com/4wU8XNVK

kdegraphics/okular
Check for strings used improperly or should be i18n.
http://pastebin.com/4WtrVU1d

kdegraphics/okular
Check for spelling errors.
http://pastebin.com/efVBTxNC

kdegraphics/okular
Check for Qt classes that should not be used
http://pastebin.com/PBCh59X9

kdegraphics/okular
Check for assignments to QString::null.
http://pastebin.com/LycX3mWi

kdegraphics/okular
Check for C++ ctors that should be declared 'explicit'
http://pastebin.com/qRpvpnii