Topic locked

[Kourse 3] Fixing krazy2 issues

User avatar msoeken
Mentor
Posts
300
Karma
4
OS

[Kourse 3] Fixing krazy2 issues

Tue Jan 06, 2009 6:45 pm
Fixing krazy2 issues

The tool Krazy Code Checker is a perl script with a collection of code checking plugins. Each day it checks the code in trunk and the results are published at English Breakfast Network. In this kourse you can learn about fixing issues found by the code checker. This increases the quality of the code. By fixing some issues, you will also learn something about common pitfalls which can be avoided in the future. Further you have to subscribe to a mailing list - a very important platform for KDE development.

Preparation

  1. Follow the instructions from Techbase to build KDE 4.2 from trunk. You should do this with an extra user, e.g. kde-devel.
  2. Choose a subject on English Breakfast Network, e.g. kdepim/ktimetracker or your favorite application.
  3. Try to fix those issues following the Why should I care? info boxes.
  4. Subscribe to the corresponding mailing list.
  5. Create a patch and send it attached to a mail to the mailing list.

Installing krazy2

It is useful to use a local krazy2 installation, because the report on English Breakfast Network is created only once a day.
  1. Follow the guide at Techbase.
  2. If you have installed it, you can run krazy2all in your source code directory.

Some tips

  • Post the patch first here. So we can have a look at it and learn together.
  • Create small patches, e.g. one patch for each category.
  • Specify the category and the subject in the mail to the mailing list and use an appropriate file name for the diff file.

Communicating in the forum

  • Please inform us about the subject you have chose as a reply to this thread, so that there are no duplicates
  • If you would like to, please post the mail to the mailing list with your patch as a reply to this thread

Last edited by bcooksley on Mon Jan 12, 2009 9:00 am, edited 1 time in total.


Image
[size=x-small]code | [url=cia.vc/stats/author/msoeken]cia.vc[/url] | [url=kde.org/support]donating KDE[/url] | [url=tinyurl.com/cto4ns]wishlist[/url][/size]
bruno
KDE Developer
Posts
40
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Mon Jan 12, 2009 9:44 pm
I choose kdeplasma-addons/applets.[hr]
Is there a list somewhere of "CMake HAVE_foo macros" ?

Last edited by bruno on Mon Jan 12, 2009 10:21 pm, edited 1 time in total.


bruno, proud to be a member of KDE forums since 2008-Oct.
michael4910
Alumni
Posts
100
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Mon Jan 12, 2009 10:39 pm
I just started with Konqueror...
There are 41 license issues and 44 copyrigh issues. Err, how does it work? Can I simply copy and paste the standard license text into those files which still don't have a license? And replace the incompatible GPL license text?
Well, what exactly I started with, is replacing Q* classes with K* classes - seems more simple to me..


michael4910, proud to be a member of KDE forums since 2008-Oct.
User avatar bcooksley
Administrator
Posts
18657
Karma
83
OS

RE: [Kourse 3] Fixing krazy2 issues

Mon Jan 12, 2009 10:44 pm
Copyright + License issues would be best resolved by contacting the Author(s) of the files in question, and request that they fix those problems. Please do not change the license text, or change their details without contacting them first.

You should feel free to fix all other Krazy issues however without needing to contact the Author(s)

Last edited by bcooksley on Mon Jan 12, 2009 10:46 pm, edited 1 time in total.


System Settings and Device Actions KCM maintainer
Image
bruno
KDE Developer
Posts
40
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Mon Jan 12, 2009 11:39 pm
1. Check single-char QString operations for efficiency [doublequote_chars]... Ok!

>>
kdeplasma-addons

Code: Select all
Index: lancelot/app/src/models/MessagesKmail.cpp
===================================================================
--- lancelot/app/src/models/MessagesKmail.cpp   (révision 910278)
+++ lancelot/app/src/models/MessagesKmail.cpp   (copie de travail)
@@ -128,7 +128,7 @@
             QDBusReply  ricon = m_folderinterface->normalIconPath();
             KIcon icon;
             add(
-                    name.value() + " (" + QString::number(unread) + ")", path,
+                    name.value() + " (" + QString::number(unread) + ')', path,
                     KIcon(
                             (ricon.isValid() && !ricon.value().isEmpty())
                             ? (ricon.value()) : "mail-folder-inbox"
Index: lancelot/app/src/models/ContactsKopete.cpp
===================================================================
--- lancelot/app/src/models/ContactsKopete.cpp   (révision 910278)
+++ lancelot/app/src/models/ContactsKopete.cpp   (copie de travail)
@@ -89,7 +89,7 @@
         }
 
         foreach (const QString& contact, contacts.value()) {
-            QStringList contactParts = contact.split(":");
+            QStringList contactParts = contact.split(':');
             if (contactParts.size() != 3) {
                 continue;
             }
@@ -103,7 +103,7 @@
                 continue;
             }
 
-            QString avatarPath = m_kopeteAvatarsDir + "/" + account + "/" + contactID + ".png";
+            QString avatarPath = m_kopeteAvatarsDir + '/' + account + '/' + contactID + ".png";
             add(contactName.value(), contactID,
                     KIcon(
                         (QFile::exists(avatarPath))?avatarPath:"user-online"
Index: lancelot/app/src/models/BaseModel.cpp
===================================================================
--- lancelot/app/src/models/BaseModel.cpp   (révision 910278)
+++ lancelot/app/src/models/BaseModel.cpp   (copie de travail)
@@ -92,7 +92,7 @@
 {
     int result = 0;
     foreach (const QString & serviceAlternatives, serviceNames) {
-        foreach (const QString & serviceName, serviceAlternatives.split("|")) {
+        foreach (const QString & serviceName, serviceAlternatives.split('|')) {
             if (addService(serviceName)) {
                 ++result;
                 break;
Index: lancelot/app/src/parts/LancelotPart.cpp
===================================================================
--- lancelot/app/src/parts/LancelotPart.cpp   (révision 910278)
+++ lancelot/app/src/parts/LancelotPart.cpp   (copie de travail)
@@ -356,7 +356,7 @@
 
     if (loaded) {
         if (!m_data.isEmpty()) {
-            m_data += "n";
+            m_data += 'n';
         }
         m_data += input;
         saveConfig();
@@ -393,7 +393,7 @@
     if (data.isEmpty()) {
         return false;
     }
-    return loadFromList(data.split("n"));
+    return loadFromList(data.split('n'));
 }
 
 void LancelotPart::removeModel(int index)
@@ -404,7 +404,7 @@
         delete model;
     }
 
-    QStringList configs = m_data.split("n");
+    QStringList configs = m_data.split('n');
     configs.removeAt(index);
     m_data = configs.join("n");
 
Index: lancelot/app/src/Serializator.cpp
===================================================================
--- lancelot/app/src/Serializator.cpp   (révision 910278)
+++ lancelot/app/src/Serializator.cpp   (copie de travail)
@@ -34,11 +34,11 @@
         i.next();
 
         if (!result.isEmpty()) {
-            result += "&";
+            result += '&';
         }
 
         result +=
-            QUrl::toPercentEncoding(i.key()) + "=" +
+            QUrl::toPercentEncoding(i.key()) + '=' +
             QUrl::toPercentEncoding(i.value());
     }
     return result;
@@ -48,9 +48,9 @@
 {
     QMap  result;
 
-    QStringList items = data.split("&");
+    QStringList items = data.split('&');
     foreach (const QString & item, items) {
-        QStringList broken = item.split("=");
+        QStringList broken = item.split('=');
         if (broken.size() != 2) {
             continue;
         }
Index: lancelot/libs/lancelot/Global.cpp
===================================================================
--- lancelot/libs/lancelot/Global.cpp   (révision 910278)
+++ lancelot/libs/lancelot/Global.cpp   (copie de travail)
@@ -321,7 +321,7 @@
     if (app == "lancelot") {
         app = "";
     } else {
-        app += "-";
+        app += '-';
     }
 
     d->confMain = new KConfig("lancelot" + app + "rc");
Index: weatherstation/weatherstation.cpp
===================================================================
--- weatherstation/weatherstation.cpp   (révision 910278)
+++ weatherstation/weatherstation.cpp   (copie de travail)
@@ -285,7 +285,7 @@
 
 void WeatherStation::setHumidity(QString humidity)
 {
-    humidity.replace("%", "");
+    humidity.remove('%');
     m_lcd->setNumber("humidity", humidity);
 }
 
Index: weatherstation/weatherconfig.cpp
===================================================================
--- weatherstation/weatherconfig.cpp   (révision 910278)
+++ weatherstation/weatherconfig.cpp   (copie de travail)
@@ -133,7 +133,7 @@
     if (m_dataengine) {
         QVariantList plugins = m_dataengine->query("ions").values();
         foreach (const QVariant& plugin, plugins) {
-            QStringList pluginInfo = plugin.toString().split("|");
+            QStringList pluginInfo = plugin.toString().split('|');
             providerComboBox->addItem(pluginInfo[0], pluginInfo[1]);
         }
     }
Index: previewer/previewwidget.cpp
===================================================================
--- previewer/previewwidget.cpp   (révision 910278)
+++ previewer/previewwidget.cpp   (copie de travail)
@@ -494,7 +494,7 @@
     painter->setFont(font);
     painter->setPen(Plasma::Theme::defaultTheme()->color(Plasma::Theme::TextColor));
     painter->drawText(QRect(39, 3, contentsRect.width() - 39, 30), Qt::AlignBottom | Qt::AlignLeft,
-                      " " + i18n("Previewer"));
+                      ' ' + i18n("Previewer"));
     QFontMetrics fm(font);
     int length = fm.width(i18n("Previewer") + "  ");
     font.setBold(false);
Index: bluemarble/kwinglutils.cpp
===================================================================
--- bluemarble/kwinglutils.cpp   (révision 910278)
+++ bluemarble/kwinglutils.cpp   (copie de travail)
@@ -65,7 +65,7 @@
     glVersion = MAKE_GL_VERSION(glversioninfo[0].toInt(), glversioninfo[1].toInt(),
                                     glversioninfo.count() > 2 ? glversioninfo[2].toInt() : 0);
     // Get list of supported OpenGL extensions
-    glExtensions = QString((const char*)glGetString(GL_EXTENSIONS)).split(" ");
+    glExtensions = QString((const char*)glGetString(GL_EXTENSIONS)).split(' ');
 
     // handle OpenGL extensions functions
     glResolveFunctions();
Index: news/news.cpp
===================================================================
--- news/news.cpp   (révision 910278)
+++ news/news.cpp   (copie de travail)
@@ -351,7 +351,7 @@
             }
             uint timeStamp = item["time"].toUInt();
             QString title = item["title"].toString();
-            QString description = item["description"].toString().replace(QRegExp("]*>"), "");
+            QString description = item["description"].toString().remove(QRegExp("]*>"));
             QString line;
 
             if (title != 0 && m_showTitles) {
Index: rssnow/news.cpp
===================================================================
--- rssnow/news.cpp   (révision 910278)
+++ rssnow/news.cpp   (copie de travail)
@@ -325,7 +325,7 @@
                     if (m_showdroptarget && (i == (m_layout->count() - 1))) {
                         m_feedlist.append(feeds);
                     } else {
-                        if (!m_feedlist[i-start].endsWith(" ")) {
+                        if (!m_feedlist[i-start].endsWith(' ')) {
                             m_feedlist[i-start].append(" ");
                         }
                         m_feedlist[i-start].append(feeds);
@@ -353,7 +353,7 @@
                 //group all feeds together so it can fit (only a single time):
                 QString allfeeds;
                 foreach (QString feed, m_feedlist) {
-                    if (!feed.endsWith(" ")) {
+                    if (!feed.endsWith(' ')) {
                         feed.append(" ");
                     }
                     allfeeds.append(feed);
Index: pastebin/backends/pastebinca.cpp
===================================================================
--- pastebin/backends/pastebinca.cpp   (révision 910278)
+++ pastebin/backends/pastebinca.cpp   (copie de travail)
@@ -44,7 +44,7 @@
     }
 
     QString url(_data);
-    url.replace("SUCCESS:","");
+    url.remove("SUCCESS:");
     url.prepend(QString("%1/").arg(m_server));
     emit postFinished(url);
 }



For the "Check for cpp macros and usage" thing, is there a list of "CMake HAVE_foo macros." ?


bruno, proud to be a member of KDE forums since 2008-Oct.
fengshaun
Alumni
Posts
32
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Mon Jan 12, 2009 11:41 pm
I will choose kdelibs/solid. I've used it before, it would be interesting to look at the code and enjoy!
77 total issues. I'll get to them as soon as I finish studying for my test tomorrow (about 2-3 hours from now!).


A proud KDE user and Linux enthusiast.
bruno
KDE Developer
Posts
40
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Mon Jan 12, 2009 11:46 pm
msoeken wrote:[*]Post the patch first here. So we can have a look at it and learn together.
[*]Create small patches, e.g. one patch for each category.


by "One patch for each category" do you mean one patch for kdeplasma-addons/applets, or one for each category of problem, like sigsandslots, spelling... ?


bruno, proud to be a member of KDE forums since 2008-Oct.
bruno
KDE Developer
Posts
40
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 2:52 am
Only 2 issue left, I think they may be falses positives as I don't think config.h is the same as "config-lancelot.h".

I hope the patch is not too big, It was only 62 issues. I didn't thought it would take that long.

Files Processed = 339
Total Issues = 2 ...as of January 12 2009 21:49:40 EST

==>For File Type c++>>
kdeplasma-addons
[code]Index: lancelot/app/src/LancelotWindow.h
===================================================================
--- lancelot/app/src/LancelotWindow.h (révision 910278)
+++ lancelot/app/src/LancelotWindow.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTWINDOW_H_
-#define LANCELOTWINDOW_H_
+#ifndef LANCELOTWINDOW_H
+#define LANCELOTWINDOW_H

#include
#include
@@ -26,6 +26,8 @@
#include
#include
#include
+#include
+#include

#include
#include "LancelotConfig.h"
@@ -251,4 +253,4 @@
friend class CustomGraphicsView;
};

-#endif /*LANCELOTWINDOW_H_*/
+#endif /*LANCELOTWINDOW_H*/
Index: lancelot/app/src/models/BaseModel.h
===================================================================
--- lancelot/app/src/models/BaseModel.h (révision 910278)
+++ lancelot/app/src/models/BaseModel.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_BASEMODEL_H_
-#define LANCELOTAPP_MODELS_BASEMODEL_H_
+#ifndef LANCELOTAPP_MODELS_BASEMODEL_H
+#define LANCELOTAPP_MODELS_BASEMODEL_H

#include
#include
@@ -84,4 +84,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_BASEMODEL_H_ */
+#endif /* LANCELOTAPP_MODELS_BASEMODEL_H */
Index: lancelot/app/src/models/FolderModel.h
===================================================================
--- lancelot/app/src/models/FolderModel.h (révision 910278)
+++ lancelot/app/src/models/FolderModel.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_FOLDERMODEL_H_
-#define LANCELOTAPP_MODELS_FOLDERMODEL_H_
+#ifndef LANCELOTAPP_MODELS_FOLDERMODEL_H
+#define LANCELOTAPP_MODELS_FOLDERMODEL_H

#include "BaseModel.h"
#include
@@ -49,4 +49,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_FOLDERMODEL_H_ */
+#endif /* LANCELOTAPP_MODELS_FOLDERMODEL_H */
Index: lancelot/app/src/models/RecentDocuments.h
===================================================================
--- lancelot/app/src/models/RecentDocuments.h (révision 910278)
+++ lancelot/app/src/models/RecentDocuments.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_RECENTDOCUMENTS_H_
-#define LANCELOTAPP_MODELS_RECENTDOCUMENTS_H_
+#ifndef LANCELOTAPP_MODELS_RECENTDOCUMENTS_H
+#define LANCELOTAPP_MODELS_RECENTDOCUMENTS_H

#include "FolderModel.h"
#include
@@ -34,4 +34,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_RECENTDOCUMENTS_H_ */
+#endif /* LANCELOTAPP_MODELS_RECENTDOCUMENTS_H */
Index: lancelot/app/src/models/Places.h
===================================================================
--- lancelot/app/src/models/Places.h (révision 910278)
+++ lancelot/app/src/models/Places.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_PLACES_H_
-#define LANCELOTAPP_MODELS_PLACES_H_
+#ifndef LANCELOTAPP_MODELS_PLACES_H
+#define LANCELOTAPP_MODELS_PLACES_H

#include "BaseModel.h"

@@ -36,4 +36,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_PLACES_H_ */
+#endif /* LANCELOTAPP_MODELS_PLACES_H */
Index: lancelot/app/src/models/Runner.h
===================================================================
--- lancelot/app/src/models/Runner.h (révision 910278)
+++ lancelot/app/src/models/Runner.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_RUNNER_H_
-#define LANCELOTAPP_MODELS_RUNNER_H_
+#ifndef LANCELOTAPP_MODELS_RUNNER_H
+#define LANCELOTAPP_MODELS_RUNNER_H

#include "BaseModel.h"
#include
@@ -54,4 +54,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_DEVICES_H_ */
+#endif /* LANCELOTAPP_MODELS_DEVICES_H */
Index: lancelot/app/src/models/NewDocuments.h
===================================================================
--- lancelot/app/src/models/NewDocuments.h (révision 910278)
+++ lancelot/app/src/models/NewDocuments.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_NEWDOCUMENTS_H_
-#define LANCELOTAPP_MODELS_NEWDOCUMENTS_H_
+#ifndef LANCELOTAPP_MODELS_NEWDOCUMENTS_H
+#define LANCELOTAPP_MODELS_NEWDOCUMENTS_H

#include "BaseModel.h"

@@ -37,4 +37,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_NEWDOCUMENTS_H_ */
+#endif /* LANCELOTAPP_MODELS_NEWDOCUMENTS_H */
Index: lancelot/app/src/models/BaseMergedModel.h
===================================================================
--- lancelot/app/src/models/BaseMergedModel.h (révision 910278)
+++ lancelot/app/src/models/BaseMergedModel.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_BASEMERGEDMODEL_H_
-#define LANCELOTAPP_MODELS_BASEMERGEDMODEL_H_
+#ifndef LANCELOTAPP_MODELS_BASEMERGEDMODEL_H
+#define LANCELOTAPP_MODELS_BASEMERGEDMODEL_H

#include

@@ -41,4 +41,4 @@

} // namespace Models

-#endif // LANCELOTAPP_MODELS_BASEMERGEDMODEL_H_
+#endif // LANCELOTAPP_MODELS_BASEMERGEDMODEL_H
Index: lancelot/app/src/models/Devices.h
===================================================================
--- lancelot/app/src/models/Devices.h (révision 910278)
+++ lancelot/app/src/models/Devices.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_DEVICES_H_
-#define LANCELOTAPP_MODELS_DEVICES_H_
+#ifndef LANCELOTAPP_MODELS_DEVICES_H
+#define LANCELOTAPP_MODELS_DEVICES_H

#include "BaseModel.h"
#include
@@ -64,4 +64,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_DEVICES_H_ */
+#endif /* LANCELOTAPP_MODELS_DEVICES_H */
Index: lancelot/app/src/models/OpenDocuments.h
===================================================================
--- lancelot/app/src/models/OpenDocuments.h (révision 910278)
+++ lancelot/app/src/models/OpenDocuments.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_OPENDOCUMENTS_H_
-#define LANCELOTAPP_MODELS_OPENDOCUMENTS_H_
+#ifndef LANCELOTAPP_MODELS_OPENDOCUMENTS_H
+#define LANCELOTAPP_MODELS_OPENDOCUMENTS_H

#include "BaseModel.h"
#include
@@ -63,4 +63,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_OPENDOCUMENTS_H_ */
+#endif /* LANCELOTAPP_MODELS_OPENDOCUMENTS_H */
Index: lancelot/app/src/models/MessagesKmail.h
===================================================================
--- lancelot/app/src/models/MessagesKmail.h (révision 910278)
+++ lancelot/app/src/models/MessagesKmail.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_MESSAGESKMAIL_H_
-#define LANCELOTAPP_MODELS_MESSAGESKMAIL_H_
+#ifndef LANCELOTAPP_MODELS_MESSAGESKMAIL_H

+#define LANCELOTAPP_MODELS_MESSAGESKMAIL_H

#include "kmail_interface.h"
#include "kmailfolder_interface.h"
@@ -55,6 +55,6 @@

} // namespace Models

-#endif // LANCELOTAPP_MODELS_MESSAGESKMAIL_H_
+#endif // LANCELOTAPP_MODELS_MESSAGESKMAIL_H


Index: lancelot/app/src/models/FavoriteApplications.h
===================================================================
--- lancelot/app/src/models/FavoriteApplications.h (révision 910278)
+++ lancelot/app/src/models/FavoriteApplications.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_FAVORITE_APPLICATIONS_H_
-#define LANCELOTAPP_MODELS_FAVORITE_APPLICATIONS_H_
+#ifndef LANCELOTAPP_MODELS_FAVORITE_APPLICATIONS_H
+#define LANCELOTAPP_MODELS_FAVORITE_APPLICATIONS_H

#include "BaseModel.h"
#include
@@ -58,4 +58,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_FAVORITE_APPLICATIONS_H_ */
+#endif /* LANCELOTAPP_MODELS_FAVORITE_APPLICATIONS_H */
Index: lancelot/app/src/models/ContactsKopete.h
===================================================================
--- lancelot/app/src/models/ContactsKopete.h (révision 910278)
+++ lancelot/app/src/models/ContactsKopete.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_CONTACTSKOPETE_H_
-#define LANCELOTAPP_MODELS_CONTACTSKOPETE_H_
+#ifndef LANCELOTAPP_MODELS_CONTACTSKOPETE_H
+#define LANCELOTAPP_MODELS_CONTACTSKOPETE_H

#include "kopete_interface.h"
#include "BaseModel.h"
@@ -46,6 +46,6 @@

} // namespace Models

-#endif // LANCELOTAPP_MODELS_CONTACTSKOPETE_H_
+#endif // LANCELOTAPP_MODELS_CONTACTSKOPETE_H


Index: lancelot/app/src/models/Applications.h
===================================================================
--- lancelot/app/src/models/Applications.h (révision 910278)
+++ lancelot/app/src/models/Applications.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_APPLICATIONS_H_
-#define LANCELOTAPP_MODELS_APPLICATIONS_H_
+#ifndef LANCELOTAPP_MODELS_APPLICATIONS_H
+#define LANCELOTAPP_MODELS_APPLICATIONS_H

#include "BaseModel.h"
#include
@@ -78,4 +78,4 @@

} // namespace Models

-#endif /* LANCELOTAPP_MODELS_APPLICATIONS_H_ */
+#endif /* LANCELOTAPP_MODELS_APPLICATIONS_H */
Index: lancelot/app/src/models/SystemServices.h
===================================================================
--- lancelot/app/src/models/SystemServices.h (révision 910278)
+++ lancelot/app/src/models/SystemServices.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_MODELS_SYSTEMSERVICES_H_
-#define LANCELOTAPP_MODELS_SYSTEMSERVICES_H_
+#ifndef LANCELOTAPP_MODELS_SYSTEMSERVICES_H
+#define LANCELOTAPP_MODELS_SYSTEMSERVICES_H

#include "BaseModel.h"

@@ -37,4 +37,4 @@

}

-#endif /* LANCELOTAPP_MODELS_SYSTEMSERVICES_H_ */
+#endif /* LANCELOTAPP_MODELS_SYSTEMSERVICES_H */
Index: lancelot/app/src/parts/LancelotPartConfig.h
===================================================================
--- lancelot/app/src/parts/LancelotPartConfig.h (révision 910278)
+++ lancelot/app/src/parts/LancelotPartConfig.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_LAUNCHER_APPLET_CONFIG_H_
-#define LANCELOT_LAUNCHER_APPLET_CONFIG_H_
+#ifndef LANCELOT_PART_CONFIG_H
+#define LANCELOT_PART_CONFIG_H

#include
#include
Index: lancelot/app/src/parts/PartsMergedModel.h
===================================================================
--- lancelot/app/src/parts/PartsMergedModel.h (révision 910278)
+++ lancelot/app/src/parts/PartsMergedModel.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTPARTS_MODELS_PARTSMERGEDMODEL_H_
-#define LANCELOTPARTS_MODELS_PARTSMERGEDMODEL_H_
+#ifndef LANCELOTPARTS_MODELS_PARTSMERGEDMODEL_H
+#define LANCELOTPARTS_MODELS_PARTSMERGEDMODEL_H

#include "../models/BaseMergedModel.h"

@@ -43,6 +43,6 @@

} // namespace Models

-#endif // LANCELOTPARTS_MODELS_PARTSMERGEDMODEL_H_
+#endif // LANCELOTPARTS_MODELS_PARTSMERGEDMODEL_H


Index: lancelot/app/src/AboutData.h
===================================================================
--- lancelot/app/src/AboutData.h (révision 910278)
+++ lancelot/app/src/AboutData.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPP_ABOUT_DATA_H_
-#define LANCELOTAPP_ABOUT_DATA_H_
+#ifndef LANCELOTAPP_ABOUT_DATA_H
+#define LANCELOTAPP_ABOUT_DATA_H

#include

@@ -27,6 +27,6 @@
AboutData();
};

-#endif // LANCELOTAPP_ABOUT_DATA_H_
+#endif // LANCELOTAPP_ABOUT_DATA_H


Index: lancelot/app/src/Serializator.h
===================================================================
--- lancelot/app/src/Serializator.h (révision 910278)
+++ lancelot/app/src/Serializator.h (copie de travail)
@@ -17,6 +17,9 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

+#ifndef LANCELOT_SERIALIZATOR_H
+#define LANCELOT_SERIALIZATOR_H
+
#include

class Serializator {
@@ -24,4 +27,4 @@
static QString serialize(const QMap data);
static QMap deserialize(const QString & data);
};
-
+#endif /* LANCELOT_SERIALIZATOR_H */
Index: lancelot/app/src/launcher/LancelotAppletConfig.h
===================================================================
--- lancelot/app/src/launcher/LancelotAppletConfig.h (révision 910278)
+++ lancelot/app/src/launcher/LancelotAppletConfig.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_LAUNCHER_APPLET_CONFIG_H_
-#define LANCELOT_LAUNCHER_APPLET_CONFIG_H_
+#ifndef LANCELOT_APPLET_CONFIG_H
+#define LANCELOT_APPLET_CONFIG_H

#include

Index: lancelot/app/src/launcher/LancelotApplet.h
===================================================================
--- lancelot/app/src/launcher/LancelotApplet.h (révision 910278)
+++ lancelot/app/src/launcher/LancelotApplet.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_LAUNCHER_APPLET_H_
-#define LANCELOT_LAUNCHER_APPLET_H_
+#ifndef LANCELOT_APPLET_H
+#define LANCELOT_APPLET_H

#include
#include
Index: lancelot/app/src/LancelotApplication.cpp
===================================================================
--- lancelot/app/src/LancelotApplication.cpp (révision 910278)
+++ lancelot/app/src/LancelotApplication.cpp (copie de travail)
@@ -17,6 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

+#include "LancelotApplication.h"
+
#include
#include
#include
@@ -25,12 +27,10 @@
#include

#include
-#include
#include

#include
#include "LancelotWindow.h"
-#include "LancelotApplication.h"
#include "models/BaseModel.h"

#include "lancelotadaptor.h"
Index: lancelot/app/src/LancelotWindow.cpp
===================================================================
--- lancelot/app/src/LancelotWindow.cpp (révision 910278)
+++ lancelot/app/src/LancelotWindow.cpp (copie de travail)
@@ -22,6 +22,8 @@

#include
#include
+#include
+#include

#include
#include
Index: lancelot/app/src/LancelotApplication.h
===================================================================
--- lancelot/app/src/LancelotApplication.h (révision 910278)
+++ lancelot/app/src/LancelotApplication.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPPLICATION_H_
-#define LANCELOTAPPLICATION_H_
+#ifndef LANCELOTAPPLICATION_H
+#define LANCELOTAPPLICATION_H

#include
#include
@@ -81,4 +81,4 @@

};

-#endif /*LANCELOTAPPLICATION_H_*/
+#endif /*LANCELOTAPPLICATION_H*/
Index: lancelot/app/src/LancelotConfig.h
===================================================================
--- lancelot/app/src/LancelotConfig.h (révision 910278)
+++ lancelot/app/src/LancelotConfig.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTCONFIG_H_
-#define LANCELOTCONFIG_H_
+#ifndef LANCELOTCONFIG_H
+#define LANCELOTCONFIG_H

#include "ui_LancelotConfigBase.h"
#include
@@ -56,6 +56,6 @@
KConfigGroup m_mainConfig;
};

-#endif // LANCELOTCONFIG_H_
+#endif // LANCELOTCONFIG_H


Index: lancelot/tools/puck/generator/hacks/qgraphicslayoutitem.h
===================================================================
--- lancelot/tools/puck/generator/hacks/qgraphicslayoutitem.h (révision 910278)
+++ lancelot/tools/puck/generator/hacks/qgraphicslayoutitem.h (copie de travail)
@@ -1,3 +1,5 @@
+#ifndef LANCELOT_QGRAPHICS_LAYOUT_ITEM_H
+#define LANCELOT_QGRAPHICS_LAYOUT_ITEM_H

class Q_GUI_EXPORT QGraphicsLayoutItem
{
@@ -13,5 +15,5 @@
Q_PROPERTY ( qreal preferredWidth READ preferredWidth WRITE setPreferredWidth )
Q_PROPERTY ( qreal preferredHeight READ preferredHeight WRITE setPreferredHeight )

-}
-
+};
+#endif /* LANCELOT_QGRAPHICS_LAYOUT_ITEM_H */
Index: lancelot/tools/puck/generator/hacks/qgraphicslayout.h
===================================================================
--- lancelot/tools/puck/generator/hacks/qgraphicslayout.h (révision 910278)
+++ lancelot/tools/puck/generator/hacks/qgraphicslayout.h (copie de travail)
@@ -1,3 +1,5 @@
+#ifndef LANCELOT_QGRAPHICS_LAYOUT_H
+#define LANCELOT_QGRAPHICS_LAYOUT_H

class Q_GUI_EXPORT QGraphicsLayout : public QGraphicsLayoutItem
{
@@ -3,2 +5,3 @@
};

+#endif /* LANCELOT_QGRAPHICS_LAYOUT_H */
Index: lancelot/tools/puck/generator/hacks/qgraphicswidget.h
===================================================================
--- lancelot/tools/puck/generator/hacks/qgraphicswidget.h (révision 910278)
+++ lancelot/tools/puck/generator/hacks/qgraphicswidget.h (copie de travail)
@@ -1,3 +1,5 @@
+#ifndef LANCELOT_QGRAPHICS_WIDGET_H
+#define LANCELOT_QGRAPHICS_WIDGET_H

class Q_GUI_EXPORT QGraphicsWidget : public QGraphicsLayoutItem
{
@@ -11,4 +13,5 @@
Q_PROPERTY(bool visible READ isVisible WRITE setVisible)
Q_PROPERTY(Qt::WindowFlags windowFlags READ windowFlags WRITE setWindowFlags)
Q_PROPERTY(QString windowTitle READ windowTitle WRITE setWindowTitle)
-}
+};
+#endif /* LANCELOT_QGRAPHICS_WIDGET_H */
Index: lancelot/libs/lancelot/layouts/ColumnLayout.h
===================================================================
--- lancelot/libs/lancelot/layouts/ColumnLayout.h (révision 910278)
+++ lancelot/libs/lancelot/layouts/ColumnLayout.h (copie de travail)
@@ -17,12 +17,12 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_COLUMN_LAYOUT_H_
-#define LANCELOT_COLUMN_LAYOUT_H_
+#ifndef LANCELOT_COLUMN_LAYOUT_H
+#define LANCELOT_COLUMN_LAYOUT_H

#include
-#include
-#include
+#include
+#include

namespace Lancelot
{
@@ -149,5 +149,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_COLUMN_LAYOUT_H_ */
+#endif /* LANCELOT_COLUMN_LAYOUT_H */

Index: lancelot/libs/lancelot/layouts/FullBorderLayout.h
===================================================================
--- lancelot/libs/lancelot/layouts/FullBorderLayout.h (révision 910278)
+++ lancelot/libs/lancelot/layouts/FullBorderLayout.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_FULL_BORDER_LAYOUT_H_
-#define LANCELOT_FULL_BORDER_LAYOUT_H_
+#ifndef LANCELOT_FULL_BORDER_LAYOUT_H
+#define LANCELOT_FULL_BORDER_LAYOUT_H

#include

@@ -130,5 +130,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_FULL_BORDER_LAYOUT_H_ */
+#endif /* LANCELOT_FULL_BORDER_LAYOUT_H */

Index: lancelot/libs/lancelot/layouts/NodeLayout.h
===================================================================
--- lancelot/libs/lancelot/layouts/NodeLayout.h (révision 910278)
+++ lancelot/libs/lancelot/layouts/NodeLayout.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_NODE_LAYOUT_H_
-#define LANCELOT_NODE_LAYOUT_H_
+#ifndef LANCELOT_NODE_LAYOUT_H
+#define LANCELOT_NODE_LAYOUT_H

#include
#include
@@ -116,5 +116,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_NODE_LAYOUT_H_ */
+#endif /* LANCELOT_NODE_LAYOUT_H */

Index: lancelot/libs/lancelot/layouts/CardLayout.h
===================================================================
--- lancelot/libs/lancelot/layouts/CardLayout.h (révision 910278)
+++ lancelot/libs/lancelot/layouts/CardLayout.h (copie de travail)
@@ -17,17 +17,17 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_CARD_LAYOUT_H_
-#define LANCELOT_CARD_LAYOUT_H_
+#ifndef LANCELOT_CARD_LAYOUT_H
+#define LANCELOT_CARD_LAYOUT_H

#include

#include
-#include
+#include

-#include
-#include
-#include
+#include
+#include
+#include

namespace Lancelot
{
@@ -98,5 +98,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_CARD_LAYOUT_H_ */
+#endif /* LANCELOT_CARD_LAYOUT_H */

Index: lancelot/libs/lancelot/layouts/FlipLayout.h
===================================================================
--- lancelot/libs/lancelot/layouts/FlipLayout.h (révision 910278)
+++ lancelot/libs/lancelot/layouts/FlipLayout.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_FLIP_LAYOUT_H_
-#define LANCELOT_FLIP_LAYOUT_H_
+#ifndef LANCELOT_FLIP_LAYOUT_H
+#define LANCELOT_FLIP_LAYOUT_H

#include
#include
@@ -114,5 +114,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_FLIP_LAYOUT_H_ */
+#endif /* LANCELOT_FLIP_LAYOUT_H */

Index: lancelot/libs/lancelot/tests/LancelotTestWindow.h
===================================================================
--- lancelot/libs/lancelot/tests/LancelotTestWindow.h (révision 910278)
+++ lancelot/libs/lancelot/tests/LancelotTestWindow.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTWINDOW_H_
-#define LANCELOTWINDOW_H_
+#ifndef LANCELOT_TEST_WINDOW_H
+#define LANCELOT_TEST_WINDOW_H

#include
#include
@@ -44,4 +44,4 @@
friend class CustomGraphicsView;
};

-#endif /*LANCELOTWINDOW_H_*/
+#endif /*LANCELOT_TEST_WINDOW_H*/
Index: lancelot/libs/lancelot/tests/LancelotTestApplication.cpp
===================================================================
--- lancelot/libs/lancelot/tests/LancelotTestApplication.cpp (révision 910278)
+++ lancelot/libs/lancelot/tests/LancelotTestApplication.cpp (copie de travail)
@@ -17,6 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

+#include "LancelotTestApplication.h"
+
#include
#include
#include
@@ -27,7 +29,6 @@

#include
#include "LancelotTestWindow.h"
-#include "LancelotTestApplication.h"

LancelotTestApplication * LancelotTestApplication::m_application = NULL;

Index: lancelot/libs/lancelot/tests/LancelotTestApplication.h
===================================================================
--- lancelot/libs/lancelot/tests/LancelotTestApplication.h (révision 910278)
+++ lancelot/libs/lancelot/tests/LancelotTestApplication.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOTAPPLICATION_H_
-#define LANCELOTAPPLICATION_H_
+#ifndef LANCELOT_TEST_APPLICATION_H
+#define LANCELOT_TEST_APPLICATION_H

#include
#include
@@ -46,4 +46,4 @@

};

-#endif /*LANCELOTAPPLICATION_H_*/
+#endif /*LANCELOT_TEST_APPLICATION_H*/
Index: lancelot/libs/lancelot/models/PassagewayViewModels.h
===================================================================
--- lancelot/libs/lancelot/models/PassagewayViewModels.h (révision 910278)
+++ lancelot/libs/lancelot/models/PassagewayViewModels.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_PASSAGEWAY_VIEW_MODELS_H_
-#define LANCELOT_PASSAGEWAY_VIEW_MODELS_H_
+#ifndef LANCELOT_PASSAGEWAY_VIEW_MODELS_H
+#define LANCELOT_PASSAGEWAY_VIEW_MODELS_H

#include

@@ -84,5 +84,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_PASSAGEWAY_VIEW_MODELS_H_ */
+#endif /* LANCELOT_PASSAGEWAY_VIEW_MODELS_H */

Index: lancelot/libs/lancelot/models/ActionListViewModels.h
===================================================================
--- lancelot/libs/lancelot/models/ActionListViewModels.h (révision 910278)
+++ lancelot/libs/lancelot/models/ActionListViewModels.h (copie de travail)
@@ -17,18 +17,18 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_ACTION_LIST_VIEW_MODELS_H_
-#define LANCELOT_ACTION_LIST_VIEW_MODELS_H_
+#ifndef LANCELOT_ACTION_LIST_VIEW_MODELS_H
+#define LANCELOT_ACTION_LIST_VIEW_MODELS_H

#include

-#include
-#include
-#include
-#include
-#include
-#include
-#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include

namespace Lancelot
{
@@ -419,5 +419,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_ACTION_LIST_VIEW_MODELS_H_ */
+#endif /* LANCELOT_ACTION_LIST_VIEW_MODELS_H */

Index: lancelot/libs/lancelot/widgets/PassagewayView.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/PassagewayView.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/PassagewayView.cpp (copie de travail)
@@ -20,6 +20,9 @@
#include "PassagewayView.h"

#include
+#include
+#include
+#include

namespace Lancelot {

Index: lancelot/libs/lancelot/widgets/HoverIcon.h
===================================================================
--- lancelot/libs/lancelot/widgets/HoverIcon.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/HoverIcon.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_HOVER_ICON_H_
-#define LANCELOT_HOVER_ICON_H_
+#ifndef LANCELOT_HOVER_ICON_H
+#define LANCELOT_HOVER_ICON_H

#include
#include
@@ -98,6 +98,6 @@

} // namespace Lancelot

-#endif /* LANCELOT_HOVER_ICON_H_ */
+#endif /* LANCELOT_HOVER_ICON_H */


Index: lancelot/libs/lancelot/widgets/ResizeBordersPanel.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/ResizeBordersPanel.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/ResizeBordersPanel.cpp (copie de travail)
@@ -17,9 +17,10 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

+#include "ResizeBordersPanel.h"
+
#include

-#include "ResizeBordersPanel.h"
#include "Widget.h"

#define COLOR 255,0,0
Index: lancelot/libs/lancelot/widgets/ScrollPane.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/ScrollPane.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/ScrollPane.cpp (copie de travail)
@@ -17,9 +17,11 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

+#include "ScrollPane.h"
+
#include
+#include

-#include "ScrollPane.h"
#include "ScrollBar.h"
#include "Widget.h"
#include
Index: lancelot/libs/lancelot/widgets/Panel.h
===================================================================
--- lancelot/libs/lancelot/widgets/Panel.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/Panel.h (copie de travail)
@@ -17,15 +17,15 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_PANEL_H_
-#define LANCELOT_PANEL_H_
+#ifndef LANCELOT_PANEL_H
+#define LANCELOT_PANEL_H

#include
#include

#include

-#include
+#include

namespace Lancelot
{
@@ -141,5 +141,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_PANEL_H_*/
+#endif /* LANCELOT_PANEL_H */

Index: lancelot/libs/lancelot/widgets/PassagewayView.h
===================================================================
--- lancelot/libs/lancelot/widgets/PassagewayView.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/PassagewayView.h (copie de travail)
@@ -17,14 +17,14 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_PASSAGEWAY_VIEW_H_
-#define LANCELOT_PASSAGEWAY_VIEW_H_
+#ifndef LANCELOT_PASSAGEWAY_VIEW_H
+#define LANCELOT_PASSAGEWAY_VIEW_H

#include
#include

#include
-#include
+#include

#include
#include
@@ -35,7 +35,7 @@
#include

#include
-#include
+#include

namespace Lancelot
{
@@ -91,5 +91,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_PASSAGEWAY_VIEW_H_ */
+#endif /* LANCELOT_PASSAGEWAY_VIEW_H */

Index: lancelot/libs/lancelot/widgets/WidgetPositioner.h
===================================================================
--- lancelot/libs/lancelot/widgets/WidgetPositioner.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/WidgetPositioner.h (copie de travail)
@@ -17,14 +17,14 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_WIDGET_POSITIONER_H_
-#define LANCELOT_WIDGET_POSITIONER_H_
+#ifndef LANCELOT_WIDGET_POSITIONER_H
+#define LANCELOT_WIDGET_POSITIONER_H

#include

#include
-#include
-#include
+#include
+#include

namespace Lancelot
{
@@ -56,5 +56,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_WIDGET_POSITIONER_H_ */
+#endif /* LANCELOT_WIDGET_POSITIONER_H */

Index: lancelot/libs/lancelot/widgets/CustomListView.h
===================================================================
--- lancelot/libs/lancelot/widgets/CustomListView.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/CustomListView.h (copie de travail)
@@ -17,13 +17,11 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_CUSTOM_LIST_VIEW_H_
-#define LANCELOT_CUSTOM_LIST_VIEW_H_
+#ifndef LANCELOT_CUSTOM_LIST_VIEW_H
+#define LANCELOT_CUSTOM_LIST_VIEW_H

#include

-#include
-#include
#include
#include

@@ -163,5 +161,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_CUSTOM_LIST_VIEW_H_ */
+#endif /* LANCELOT_CUSTOM_LIST_VIEW_H */

Index: lancelot/libs/lancelot/widgets/ResizeBordersPanel.h
===================================================================
--- lancelot/libs/lancelot/widgets/ResizeBordersPanel.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/ResizeBordersPanel.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_RESIZE_BORDERS_PANEL_H_
-#define LANCELOT_RESIZE_BORDERS_PANEL_H_
+#ifndef LANCELOT_RESIZE_BORDERS_PANEL_H
+#define LANCELOT_RESIZE_BORDERS_PANEL_H

#include

@@ -58,5 +58,5 @@

} // namespace Lancelot

-#endif // LANCELOT_RESIZE_BORDERS_PANEL_H_
+#endif // LANCELOT_RESIZE_BORDERS_PANEL_H

Index: lancelot/libs/lancelot/widgets/ScrollPane.h
===================================================================
--- lancelot/libs/lancelot/widgets/ScrollPane.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/ScrollPane.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_SCROLL_PANE_H_
-#define LANCELOT_SCROLL_PANE_H_
+#ifndef LANCELOT_SCROLL_PANE_H
+#define LANCELOT_SCROLL_PANE_H

#include

@@ -198,5 +198,5 @@

Q_DECLARE_OPERATORS_FOR_FLAGS(Lancelot::ScrollPane::Flags)

-#endif // LANCELOT_SCROLL_PANE_H_
+#endif // LANCELOT_SCROLL_PANE_H

Index: lancelot/libs/lancelot/widgets/ActionListView.h
===================================================================
--- lancelot/libs/lancelot/widgets/ActionListView.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/ActionListView.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_ACTION_LIST_VIEW_H_
-#define LANCELOT_ACTION_LIST_VIEW_H_
+#ifndef LANCELOT_ACTION_LIST_VIEW_H
+#define LANCELOT_ACTION_LIST_VIEW_H

#ifndef LANCELOT_ACTION_LIST_VIEW2_OVERRIDE
#define LANCELOT_ACTION_LIST_VIEW2_OVERRIDE
@@ -32,10 +32,8 @@
#include
#include

-#include
-#include
-#include
-#include
+#include
+#include

#include
#include
@@ -191,5 +189,5 @@
} // namespace Lancelot

#endif
-#endif /* LANCELOT_ACTION_LIST_VIEW_H_ */
+#endif /* LANCELOT_ACTION_LIST_VIEW_H */

Index: lancelot/libs/lancelot/widgets/ExtenderButton.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/ExtenderButton.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/ExtenderButton.cpp (copie de travail)
@@ -22,6 +22,7 @@
#include
#include
#include
+#include

#define ACTIVATION_TIME 300

Index: lancelot/libs/lancelot/widgets/ActionListView2_p.h
===================================================================
--- lancelot/libs/lancelot/widgets/ActionListView2_p.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/ActionListView2_p.h (copie de travail)
@@ -17,14 +17,12 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_ACTION_LIST_VIEW2_PH_
-#define LANCELOT_ACTION_LIST_VIEW2_PH_
+#ifndef LANCELOT_ACTION_LIST_VIEW2_PH
+#define LANCELOT_ACTION_LIST_VIEW2_PH

#include
#include

-#include
-#include
#include
#include

@@ -142,5 +140,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_ACTION_LIST_VIEW2_PH_ */
+#endif /* LANCELOT_ACTION_LIST_VIEW2_PH */

Index: lancelot/libs/lancelot/widgets/ExtenderButton.h
===================================================================
--- lancelot/libs/lancelot/widgets/ExtenderButton.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/ExtenderButton.h (copie de travail)
@@ -17,15 +17,12 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_EXTENDER_BUTTON_H_
-#define LANCELOT_EXTENDER_BUTTON_H_
+#ifndef LANCELOT_EXTENDER_BUTTON_H
+#define LANCELOT_EXTENDER_BUTTON_H

#include
#include

-#include
-#include
-
#include
#include

@@ -184,5 +181,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_EXTENDER_BUTTON_H_ */
+#endif /* LANCELOT_EXTENDER_BUTTON_H */

Index: lancelot/libs/lancelot/widgets/ScrollBar.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/ScrollBar.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/ScrollBar.cpp (copie de travail)
@@ -21,6 +21,8 @@
#include

#include "ExtenderButton.h"
+#include
+#include

namespace Lancelot
{
Index: lancelot/libs/lancelot/widgets/Widget.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/Widget.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/Widget.cpp (copie de travail)
@@ -17,12 +17,16 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

+#include "Widget.h"
+
#include
-#include "Widget.h"
#include "Global.h"
#include
#include

+#include
+#include
+
namespace Lancelot {

class Widget::Private {
Index: lancelot/libs/lancelot/widgets/BasicWidget.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/BasicWidget.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/BasicWidget.cpp (copie de travail)
@@ -22,6 +22,7 @@
#include
#include "Global.h"
#include
+#include

#define WIDGET_PADDING 8

Index: lancelot/libs/lancelot/widgets/ActionListView2.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/ActionListView2.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/ActionListView2.cpp (copie de travail)
@@ -20,6 +20,9 @@
#include "ActionListView2.h"
#include "ActionListView2_p.h"

+#include
+#include
+
namespace Lancelot {

//> ActionListView2Item
Index: lancelot/libs/lancelot/widgets/ScrollBar.h
===================================================================
--- lancelot/libs/lancelot/widgets/ScrollBar.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/ScrollBar.h (copie de travail)
@@ -17,14 +17,12 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_SCROLL_BAR_H_
-#define LANCELOT_SCROLL_BAR_H_
+#ifndef LANCELOT_SCROLL_BAR_H
+#define LANCELOT_SCROLL_BAR_H

#include
#include

-#include
-#include
#include

namespace Lancelot
@@ -197,4 +195,4 @@

} // namespace Lancelot

-#endif /* LANCELOT_SCROLL_BAR_H_ */
+#endif /* LANCELOT_SCROLL_BAR_H */
Index: lancelot/libs/lancelot/widgets/Widget.h
===================================================================
--- lancelot/libs/lancelot/widgets/Widget.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/Widget.h (copie de travail)
@@ -17,18 +17,17 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_WIDGET_H_
-#define LANCELOT_WIDGET_H_
+#ifndef LANCELOT_WIDGET_H
+#define LANCELOT_WIDGET_H

-#include
+#include

#include
#include

#include

-#include
-#include
+#include

namespace Lancelot
{
@@ -194,5 +193,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_WIDGET_H_ */
+#endif /* LANCELOT_WIDGET_H */

Index: lancelot/libs/lancelot/widgets/BasicWidget.h
===================================================================
--- lancelot/libs/lancelot/widgets/BasicWidget.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/BasicWidget.h (copie de travail)
@@ -17,16 +17,16 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_BASIC_WIDGET_H_
-#define LANCELOT_BASIC_WIDGET_H_
+#ifndef LANCELOT_BASIC_WIDGET_H
+#define LANCELOT_BASIC_WIDGET_H

#include
#include

-#include
-#include
#include

+#include
+#include
#include

namespace Lancelot
@@ -190,5 +190,5 @@

} // namespace Lancelot


-#endif /* LANCELOT_BASIC_WIDGET_H_ */
+#endif /* LANCELOT_BASIC_WIDGET_H */

Index: lancelot/libs/lancelot/widgets/ActionListView2.h
===================================================================
--- lancelot/libs/lancelot/widgets/ActionListView2.h (révision 910278)
+++ lancelot/libs/lancelot/widgets/ActionListView2.h (copie de travail)
@@ -17,14 +17,12 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_ACTION_LIST_VIEW2_H_
-#define LANCELOT_ACTION_LIST_VIEW2_H_
+#ifndef LANCELOT_ACTION_LIST_VIEW2_H
+#define LANCELOT_ACTION_LIST_VIEW2_H

#include
#include

-#include
-#include
#include
#include

@@ -80,5 +78,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_ACTION_LIST_VIEW2_H_ */
+#endif /* LANCELOT_ACTION_LIST_VIEW2_H */

Index: lancelot/libs/lancelot/widgets/HoverIcon.cpp
===================================================================
--- lancelot/libs/lancelot/widgets/HoverIcon.cpp (révision 910278)
+++ lancelot/libs/lancelot/widgets/HoverIcon.cpp (copie de travail)
@@ -19,6 +19,8 @@

#include "HoverIcon.h"

+#include
+
#define ACTIVATION_TIME 300

namespace Lancelot
Index: lancelot/libs/lancelot/Global.h
===================================================================
--- lancelot/libs/lancelot/Global.h (révision 910278)
+++ lancelot/libs/lancelot/Global.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_GLOBAL_H_
-#define LANCELOT_GLOBAL_H_
+#ifndef LANCELOT_GLOBAL_H
+#define LANCELOT_GLOBAL_H

#include
#include
@@ -277,5 +277,5 @@

} // namespace Lancelot

-#endif /* LANCELOT_GLOBAL_H_ */
+#endif /* LANCELOT_GLOBAL_H */

Index: lancelot/libs/lancelot/lancelot.h
===================================================================
--- lancelot/libs/lancelot/lancelot.h (révision 910278)
+++ lancelot/libs/lancelot/lancelot.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LIBLANCELOT_H_
-#define LIBLANCELOT_H_
+#ifndef LIBLANCELOT_H
+#define LIBLANCELOT_H

#include
#include
@@ -80,5 +80,5 @@

} // namespace Lancelot

-#endif // LIBLANCELOT_H_
+#endif // LIBLANCELOT_H

Index: lancelot/libs/lancelot/lancelot_export.h
===================================================================
--- lancelot/libs/lancelot/lancelot_export.h (révision 910278)
+++ lancelot/libs/lancelot/lancelot_export.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

-#ifndef LANCELOT_EXPORT_H_
-#define LANCELOT_EXPORT_H_
+#ifndef LANCELOT_EXPORT_H
+#define LANCELOT_EXPORT_H

/* needed for KDE_EXPORT and KDE_IMPORT macros */
#include
@@ -46,5 +46,5 @@
// Extra data needed by PUCK module generator. Does nothing otherwise
#define L_EXTRA(A)

-#endif // LANCELOT_EXPORT_H_
+#endif // LANCELOT_EXPORT_H

Index: bluemarble/bluemarble.cpp
===================================================================
--- bluemarble/bluemarble.cpp (révision 910278)
+++ bluemarble/bluemarble.cpp (copie de travail)
@@ -16,11 +16,11 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

+#include "bluemarble.h"
+
// has to be first
#include "kwinglutils.h"

-#include "bluemarble.h"
-
#include

#include
Index: konqprofiles/konqprofilesapplet.h
===================================================================
--- konqprofiles/konqprofilesapplet.h (révision 910278)
+++ konqprofiles/konqprofilesapplet.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA *
***************************************************************************/

-#ifndef _KONQPROFILESAPPLET_H_
-#define _KONQPROFILESAPPLET_H_
+#ifndef KONQPROFILESAPPLET_H
+#define KONQPROFILESAPPLET_H


#include
Index: charselect/charselect.cpp
===================================================================
--- charselect/charselect.cpp (révision 910278)
+++ charselect/charselect.cpp (copie de travail)
@@ -17,6 +17,7 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "charselect.h"

#include
#include
@@ -25,7 +26,6 @@
#include
#include
#include
-#include "charselect.h"

CharSelectApplet::CharSelectApplet(QObject *parent, const QVariantList &args)
: Plasma::PopupApplet(parent, args),
Index: life/life.cpp
===================================================================
--- life/life.cpp (révision 910278)
+++ life/life.cpp (copie de travail)
@@ -17,20 +17,18 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "life.h"
+
#include
#include

#include
-#include

#include
#include
#include
#include

-#include "ui_lifeConfig.h"
-#include "life.h"
-
Life::Life(QObject *parent, const QVariantList &args)
: Plasma::Applet(parent, args),
timer(this)
Index: life/life.h
===================================================================
--- life/life.h (révision 910278)
+++ life/life.h (copie de travail)
@@ -22,7 +22,10 @@

#include
#include
+#include

+#include "ui_lifeConfig.h"
+
namespace Plasma
{
class DataEngine;
Index: leavenote/leavenote.cpp
===================================================================
--- leavenote/leavenote.cpp (révision 910278)
+++ leavenote/leavenote.cpp (copie de travail)
@@ -21,6 +21,8 @@
*
*/

+#include "leavenote.h"
+
#include
#include
#include
@@ -42,8 +44,6 @@
#include
#include

-#include "leavenote.h"
-
#define MAX_CHAR 1000

LeaveNote::LeaveNote(QObject *parent, const QVariantList &args)
Index: leavenote/leavenote.h
===================================================================
--- leavenote/leavenote.h (révision 910278)
+++ leavenote/leavenote.h (copie de travail)
@@ -17,8 +17,8 @@
*/

// Here we avoid loading the header multiple times
-#ifndef Leavemsg_HEADER
-#define Leavemsg_HEADER
+#ifndef LEAVENOTE_H
+#define LEAVENOTE_H

#include
#include
@@ -89,6 +89,6 @@

// This is the command that links your applet to the .desktop file
K_EXPORT_PLASMA_APPLET(leavenote, LeaveNote)
-#endif
+#endif /* LEAVENOTE_H */

void verboseLog(QString);
Index: frame/slideshow.cpp
===================================================================
--- frame/slideshow.cpp (révision 910278)
+++ frame/slideshow.cpp (copie de travail)
@@ -17,13 +17,13 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "slideshow.h"
+
#include
-#include
#include
#include

#include "picture.h"
-#include "slideshow.h"
#include

SlideShow::SlideShow()
Index: frame/slideshow.h
===================================================================
--- frame/slideshow.h (révision 910278)
+++ frame/slideshow.h (copie de travail)
@@ -17,17 +17,16 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

-#ifndef SLIDESHOW_H_
-#define SLIDESHOW_H_
+#ifndef SLIDESHOW_H
+#define SLIDESHOW_H

#include
#include
#include
#include
#include
+#include

-class KUrl;
-
class SlideShow
{
public:
@@ -56,4 +55,4 @@

};

-#endif /*SLIDESHOW_H_*/
+#endif /*SLIDESHOW_H*/
Index: frame/configdialog.cpp
===================================================================
--- frame/configdialog.cpp (révision 910278)
+++ frame/configdialog.cpp (copie de travail)
@@ -17,11 +17,12 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "configdialog.h"
+
#include
#include
#include

-#include "configdialog.h"
#include "picture.h"

ConfigDialog::ConfigDialog(QWidget *parent)
Index: pastebin/backends/imagebinca.cpp
===================================================================
--- pastebin/backends/imagebinca.cpp (révision 910278)
+++ pastebin/backends/imagebinca.cpp (copie de travail)
@@ -19,6 +19,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "imagebinca.h"
+
#include
#include
#include
@@ -30,8 +32,6 @@
#include
#include

-#include "imagebinca.h"
-
ImagebinCAServer::ImagebinCAServer()
: PastebinServer(),
m_server("http://imagebin.ca")
Index: pastebin/backends/pastebincom.cpp
===================================================================
--- pastebin/backends/pastebincom.cpp (révision 910278)
+++ pastebin/backends/pastebincom.cpp (copie de travail)
@@ -17,11 +17,11 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "pastebincom.h"
+
#include
#include

-#include "pastebincom.h"
-
PastebinCOMServer::PastebinCOMServer()
: PastebinServer(),
m_server("http://pastebin.com")
Index: pastebin/backends/pastebinca.cpp
===================================================================
--- pastebin/backends/pastebinca.cpp (révision 910278)
+++ pastebin/backends/pastebinca.cpp (copie de travail)
@@ -18,11 +18,11 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "pastebinca.h"
+
#include
#include

-#include "pastebinca.h"
-
PastebinCAServer::PastebinCAServer()
: PastebinServer(),
m_server("http://pastebin.ca"),
Index: pastebin/backends/imageshack.cpp
===================================================================
--- pastebin/backends/imageshack.cpp (révision 910278)
+++ pastebin/backends/imageshack.cpp (copie de travail)
@@ -20,6 +20,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
***************************************************************************/

+#include "imageshack.h"
+
#include
#include
#include
@@ -31,8 +33,6 @@
#include
#include

-#include "imageshack.h"
-
ImageshackServer::ImageshackServer()
: PastebinServer(),
m_server("http://imageshack.us")
Index: konsoleprofiles/konsoleprofilesapplet.h
===================================================================
--- konsoleprofiles/konsoleprofilesapplet.h (révision 910278)
+++ konsoleprofiles/konsoleprofilesapplet.h (copie de travail)
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA *
***************************************************************************/

-#ifndef _KONSOLEPROFILESAPPLET_H_
-#define _KONSOLEPROFILESAPPLET_H_
+#ifndef KONSOLEPROFILESAPPLET_H
+#define KONSOLEPROFILESAPPLET_H

#include

[/code]

Last edited by bruno on Tue Jan 13, 2009 2:53 am, edited 1 time in total.


bruno, proud to be a member of KDE forums since 2008-Oct.
fengshaun
Alumni
Posts
32
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 3:47 am
is it possible to do a recursive krazy2 search in a directory?

I have a solid.new and a solid.orig (to diff later on) and I want to do a recursive krazy2 search on solid.new.[hr]
Uh, I think I got it, I just used $ krazy2all solid.new

Last edited by fengshaun on Tue Jan 13, 2009 3:49 am, edited 1 time in total.


A proud KDE user and Linux enthusiast.
User avatar msoeken
Mentor
Posts
300
Karma
4
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 7:30 am
bruno wrote:I choose kdeplasma-addons/applets.[hr]
Is there a list somewhere of "CMake HAVE_foo macros" ?


I have no idea by now. But I will try to find it out and let you know.[hr]
michael4910 wrote:I just started with Konqueror...
There are 41 license issues and 44 copyrigh issues. Err, how does it work? Can I simply copy and paste the standard license text into those files which still don't have a license? And replace the incompatible GPL license text?


Yes, this is indeed difficult. Once I was solving krazy2 issues where there was no copyright owner in the license text. I had to check the logs of the svn repository to get the authors.[hr]
bruno wrote:Only 2 issue left, I think they may be falses positives as I don't think config.h is the same as "config-lancelot.h".

I hope the patch is not too big, It was only 62 issues. I didn't thought it would take that long.


Can you send this patch to the mailing list. Perhaps you can find out there or in irc whether those 2 issues are false positives. If they are, have a look at Code Checking (Supressing false-positives) to suppress them in further checks.[hr]
bruno wrote:
msoeken wrote:[*]Post the patch first here. So we can have a look at it and learn together.
[*]Create small patches, e.g. one patch for each category.


by "One patch for each category" do you mean one patch for kdeplasma-addons/applets, or one for each category of problem, like sigsandslots, spelling... ?


If the patches are small, the developers can have a better look on it and faster decide whether to commit it. Perhaps after the first few patches, they say, you do a good work and then you can also send bigger patches. That's how I started and I think it is a normal way in open source programming. After some patches you can even request a SVN account, if you do not have any yet.[hr]
fengshaun wrote:is it possible to do a recursive krazy2 search in a directory?

I have a solid.new and a solid.orig (to diff later on) and I want to do a recursive krazy2 search on solid.new.[hr]
Uh, I think I got it, I just used $ krazy2all solid.new


Is there a reason to keep two directories solid.orig and solid.new? You can do
Code: Select all
svn diff

to create the patch.

Last edited by msoeken on Tue Jan 13, 2009 7:45 am, edited 1 time in total.


Image
[size=x-small]code | [url=cia.vc/stats/author/msoeken]cia.vc[/url] | [url=kde.org/support]donating KDE[/url] | [url=tinyurl.com/cto4ns]wishlist[/url][/size]
michael4910
Alumni
Posts
100
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 8:13 am
msoeken wrote:Yes, this is indeed difficult. Once I was solving krazy2 issues where there was no copyright owner in the license text. I had to check the logs of the svn repository to get the authors.


* Copyright (c) Martin R. Jones 1996

=> krazy2 says: "missing tags: email address(line 2) (1)"

Oh my Gods, please excuse me when I concentrate mainly on the other issues... ,-)
Is there a real and good reason for this "archeology"? Those files survived so long without proper email addresses and compatible licenses....


michael4910, proud to be a member of KDE forums since 2008-Oct.
pklaffert
Alumni
Posts
3
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 8:29 am
I choose kdeplasma-addons/dataengines
User avatar msoeken
Mentor
Posts
300
Karma
4
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 8:53 am
michael4910 wrote:Oh my Gods, please excuse me when I concentrate mainly on the other issues... ,-)
Is there a real and good reason for this "archeology"? Those files survived so long without proper email addresses and compatible licenses....


I am not sure but AFAIK the GPL copyrights are only valid with a name and an email address.


Image
[size=x-small]code | [url=cia.vc/stats/author/msoeken]cia.vc[/url] | [url=kde.org/support]donating KDE[/url] | [url=tinyurl.com/cto4ns]wishlist[/url][/size]
pklaffert
Alumni
Posts
3
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 10:10 am
some license and copyright issues left and these issues with explicit constructor.
i am not able to compile and test the changes since my workstation has not enough memory left to install the whole trunk version of kde

hope the changes are right anyway
Code: Select all
Index: twitter/timelinesource.cpp
===================================================================
--- twitter/timelinesource.cpp   (Revision 910380)
+++ twitter/timelinesource.cpp   (Arbeitskopie)
@@ -76,7 +76,7 @@
       m_job(0)
 {
     //who should be something like user@http://twitter.com, if there isn't any @, http://twitter.com will be the default
-    QStringList account = who.split("@");
+    QStringList account = who.split('@');
     if (account.count() == 2){
         m_serviceBaseUrl = KUrl(account.at(1));
     }else{
Index: twitter/twitterengine.cpp
===================================================================
--- twitter/twitterengine.cpp   (Revision 910380)
+++ twitter/twitterengine.cpp   (Arbeitskopie)
@@ -30,7 +30,6 @@
 #include
 #include
 #include
-#include
 
 #include "timelinesource.h"
 #include "imagesource.h"
@@ -54,7 +53,7 @@
         return true;
     }
 
-    if (!name.startsWith("Timeline:") && !name.startsWith("TimelineWithFriends:")  && !name.startsWith("Profile:")) {
+    if (!name.startsWith(QString("Timeline:")) && !name.startsWith(QString("TimelineWithFriends:"))  && !name.startsWith(QString("Profile:"))) {
         return false;
     }
 
@@ -83,17 +82,17 @@
 {
     //kDebug() pluginName() + "/" );
+    const QString path = KStandardDirs::locate( "data", "plasma/comics/" + mProvider->pluginName() + '/' );
     if ( !path.isEmpty() ) {
         mPackage = new Plasma::Package( path, ComicProviderKross::packageStructure() );
 
@@ -298,8 +298,8 @@
         foreach( const QString &interpretername, Kross::Manager::self().interpreters() ) {
             info = Kross::Manager::self().interpreterInfo( interpretername );
             wildcards = info->wildcard();
-            wildcards.replace( "*", "" );
-            mExtensions
 #include
 #include
@@ -24,7 +26,6 @@
 #include
 #include
 
-#include "cachedprovider.h"
 
 static QString identifierToPath( const QString &identifier )
 {
Index: comic/comic.cpp
===================================================================
--- comic/comic.cpp   (Revision 910380)
+++ comic/comic.cpp   (Arbeitskopie)
@@ -16,6 +16,8 @@
  *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
+#include "comic.h"
+
 #include
 #include
 #include
@@ -26,8 +28,6 @@
 
 #include
 
-#include "comic.h"
-
 #include "cachedprovider.h"
 
 ComicEngine::ComicEngine( QObject* parent, const QVariantList& args )
michael4910
Alumni
Posts
100
Karma
0
OS

RE: [Kourse 3] Fixing krazy2 issues

Tue Jan 13, 2009 10:42 am
@pklaffert: You could try out kde-nightly and just compile the app you're are coding in...
http://amarok.kde.org/wiki/User:Apachel ... n/KDE/Info


michael4910, proud to be a member of KDE forums since 2008-Oct.

 
Topic locked

Bookmarks



Who is online

Registered users: ab4bd, Baidu [Spider], BeS, Bing [Bot], Exabot [Bot], GeekQuack, ggael, ghevan, Google [Bot], google01103, igorm, jensreuterberg, kainz.a, maarten, mmistretta, Nuc!eoN, orbmiser, plfiorini, scummos, searchfgold6789, SecretCode, Steve T, TheraHedwig, Uri_Herrera, vblazquez, Yahoo [Bot]